Revise CBB and remove unnecessary code

Reviewed-on: #3
Reviewed-by: efrain_marin <efrain.marin@agilewebs.com>
Reviewed-by: Sergio Matías <sergio.matias@agilewebs.com>

Core.Thalos.BFF.Api/Controllers/AuthenticationController.cs

@@ -1,9 +1,6 @@
 using Asp.Versioning;
-using Core.Thalos.Adapters;
-using Core.Thalos.Adapters.Common.Constants;
-using Core.Thalos.Adapters.Contracts;
 using Core.Thalos.Application.UseCases.Users.Input;
-using Core.Thalos.BuildingBlocks.Authentication.Authorization.Google;
+using Core.Thalos.BuildingBlocks;
 using Core.Thalos.External.Clients.Thalos.Requests.Users;
 using LSA.Dashboard.External.Clients.Dashboard;
 using Microsoft.AspNetCore.Authorization;

Core.Thalos.BFF.Api/Controllers/ModuleController.cs

@@ -1,7 +1,5 @@
 using Asp.Versioning;
-using Core.Thalos.Adapters;
+using Core.Thalos.BuildingBlocks;
-using Core.Thalos.Adapters.Attributes;
-using Core.Thalos.Adapters.Common.Constants;
 using Core.Thalos.External.Clients.Thalos.Requests.Permissions;
 using Lib.Architecture.BuildingBlocks;
 using LSA.Dashboard.External.Clients.Dashboard;

Core.Thalos.BFF.Api/Controllers/PermissionController.cs

@@ -1,7 +1,5 @@
 using Asp.Versioning;
-using Core.Thalos.Adapters;
+using Core.Thalos.BuildingBlocks;
-using Core.Thalos.Adapters.Attributes;
-using Core.Thalos.Adapters.Common.Constants;
 using Core.Thalos.External.Clients.Thalos.Requests.Permissions;
 using Lib.Architecture.BuildingBlocks;
 using LSA.Dashboard.External.Clients.Dashboard;

Core.Thalos.BFF.Api/Controllers/RoleController.cs

@@ -1,7 +1,6 @@
 using Asp.Versioning;
-using Core.Thalos.Adapters.Attributes;
-using Core.Thalos.Adapters.Common.Constants;
 using Core.Thalos.Application.UseCases.Roles.Input;
+using Core.Thalos.BuildingBlocks;
 using Lib.Architecture.BuildingBlocks;
 using LSA.Dashboard.External.Clients.Dashboard;
 using Microsoft.AspNetCore.Authorization;

Core.Thalos.BFF.Api/Controllers/UserController.cs

@@ -1,7 +1,6 @@
 using Asp.Versioning;
-using Core.Thalos.Adapters.Attributes;
-using Core.Thalos.Adapters.Common.Constants;
 using Core.Thalos.Application.UseCases.Users.Input;
+using Core.Thalos.BuildingBlocks;
 using Core.Thalos.External.Clients.Thalos.Requests.Users;
 using Lib.Architecture.BuildingBlocks;
 using LSA.Dashboard.External.Clients.Dashboard;
@@ -76,8 +75,6 @@ namespace Core.Thalos.BFF.Api.Controllers
 
                 if (string.IsNullOrEmpty(newUser.RoleId)) return BadRequest("Invalid role id");
 
-                if (!newUser.Companies.Any()) return BadRequest("The user must contain at least one company");
-
                 return await Handle(() => thalosServiceClient.CreateUserService(newUser, cancellationToken)).ConfigureAwait(false);
             }
             catch (Exception ex)
@@ -271,135 +268,6 @@ namespace Core.Thalos.BFF.Api.Controllers
             }
         }
 
-        /// <summary>
-        /// Adds a company to the user's list of companies.
-        /// </summary>
-        [HttpPost]
-        [Route("AddCompany")]
-        [ProducesResponseType(StatusCodes.Status200OK)]
-        [ProducesResponseType(StatusCodes.Status204NoContent)]
-        [ProducesResponseType(StatusCodes.Status400BadRequest)]
-        [ProducesResponseType(StatusCodes.Status401Unauthorized)]
-        [ProducesResponseType(typeof(Notification), StatusCodes.Status412PreconditionFailed)]
-        [ProducesResponseType(typeof(Notification), StatusCodes.Status422UnprocessableEntity)]
-        [ProducesResponseType(StatusCodes.Status500InternalServerError)]
-        [Authorize(AuthenticationSchemes = Schemes.DefaultScheme)]
-        [Permission("UserManagement.Write")]
-        public async Task<IActionResult> AddCompanyToUserService([FromBody] AddCompanyToUserRequest request, CancellationToken cancellationToken)
-        {
-            try
-            {
-                logger.LogInformation($"{nameof(AddCompanyToUserService)} - Request received - Payload: {JsonSerializer.Serialize(request)}");
-
-                if (string.IsNullOrEmpty(request.UserId)) { return BadRequest("Invalid user identifier"); }
-                if (string.IsNullOrEmpty(request.CompanyId)) { return BadRequest("Invalid company identifier"); }
-
-                return await Handle(() => thalosServiceClient.AddCompanyToUserService(request, cancellationToken)).ConfigureAwait(false);
-            }
-            catch (Exception ex)
-            {
-                logger.LogError($"{nameof(AddCompanyToUserService)} - An Error Occurred- {ex.Message} - {ex.InnerException} - {ex.StackTrace} - with payload {JsonSerializer.Serialize(request)}");
-                throw;
-            }
-        }
-
-        /// <summary>
-        /// Removes a company from the user's list of companies.
-        /// </summary>
-        [HttpDelete]
-        [Route("RemoveCompany")]
-        [ProducesResponseType(StatusCodes.Status200OK)]
-        [ProducesResponseType(StatusCodes.Status204NoContent)]
-        [ProducesResponseType(StatusCodes.Status400BadRequest)]
-        [ProducesResponseType(StatusCodes.Status401Unauthorized)]
-        [ProducesResponseType(typeof(Notification), StatusCodes.Status412PreconditionFailed)]
-        [ProducesResponseType(typeof(Notification), StatusCodes.Status422UnprocessableEntity)]
-        [ProducesResponseType(StatusCodes.Status500InternalServerError)]
-        [Authorize(AuthenticationSchemes = Schemes.DefaultScheme)]
-        [Permission("UserManagement.Write")]
-        public async Task<IActionResult> RemoveCompanyFromUserService([FromBody] RemoveCompanyFromUserRequest request, CancellationToken cancellationToken)
-        {
-            try
-            {
-                logger.LogInformation($"{nameof(RemoveCompanyFromUserService)} - Request received - Payload: {JsonSerializer.Serialize(request)}");
-
-                if (string.IsNullOrEmpty(request.UserId)) { return BadRequest("Invalid user identifier"); }
-                if (string.IsNullOrEmpty(request.CompanyId)) { return BadRequest("Invalid company identifier"); }
-
-                return await Handle(() => thalosServiceClient.RemoveCompanyFromUserService(request, cancellationToken)).ConfigureAwait(false);
-            }
-            catch (Exception ex)
-            {
-                logger.LogError($"{nameof(RemoveCompanyFromUserService)} - An Error Occurred- {ex.Message} - {ex.InnerException} - {ex.StackTrace} - with payload {JsonSerializer.Serialize(request)}");
-                throw;
-            }
-        }
-
-        /// <summary>
-        /// Adds a project to the user's list of companies.
-        /// </summary>
-        [HttpPost]
-        [Route("AddProject")]
-        [ProducesResponseType(StatusCodes.Status200OK)]
-        [ProducesResponseType(StatusCodes.Status204NoContent)]
-        [ProducesResponseType(StatusCodes.Status400BadRequest)]
-        [ProducesResponseType(StatusCodes.Status401Unauthorized)]
-        [ProducesResponseType(typeof(Notification), StatusCodes.Status412PreconditionFailed)]
-        [ProducesResponseType(typeof(Notification), StatusCodes.Status422UnprocessableEntity)]
-        [ProducesResponseType(StatusCodes.Status500InternalServerError)]
-        [Authorize(AuthenticationSchemes = Schemes.DefaultScheme)]
-        [Permission("UserManagement.Write")]
-
-        public async Task<IActionResult> AddProjectToUserService([FromBody] AddProjectToUserRequest request, CancellationToken cancellationToken)
-        {
-            try
-            {
-                logger.LogInformation($"{nameof(AddProjectToUserService)} - Request received - Payload: {JsonSerializer.Serialize(request)}");
-
-                if (string.IsNullOrEmpty(request.UserId)) { return BadRequest("Invalid user identifier"); }
-                if (string.IsNullOrEmpty(request.ProjectId)) { return BadRequest("Invalid project identifier"); }
-
-                return await Handle(() => thalosServiceClient.AddProjectToUserService(request, cancellationToken)).ConfigureAwait(false);
-            }
-            catch (Exception ex)
-            {
-                logger.LogError($"{nameof(AddProjectToUserService)} - An Error Occurred- {ex.Message} - {ex.InnerException} - {ex.StackTrace} - with payload {JsonSerializer.Serialize(request)}");
-                throw;
-            }
-        }
-
-        /// <summary>
-        /// Removes a project from the user's list of companies.
-        /// </summary>
-        [HttpDelete]
-        [Route("RemoveProject")]
-        [ProducesResponseType(StatusCodes.Status200OK)]
-        [ProducesResponseType(StatusCodes.Status204NoContent)]
-        [ProducesResponseType(StatusCodes.Status400BadRequest)]
-        [ProducesResponseType(StatusCodes.Status401Unauthorized)]
-        [ProducesResponseType(typeof(Notification), StatusCodes.Status412PreconditionFailed)]
-        [ProducesResponseType(typeof(Notification), StatusCodes.Status422UnprocessableEntity)]
-        [ProducesResponseType(StatusCodes.Status500InternalServerError)]
-        [Authorize(AuthenticationSchemes = Schemes.DefaultScheme)]
-        [Permission("UserManagement.Write")]
-        public async Task<IActionResult> RemoveProjectFromUserService([FromBody] RemoveProjectFromUserRequest request, CancellationToken cancellationToken)
-        {
-            try
-            {
-                logger.LogInformation($"{nameof(RemoveProjectFromUserService)} - Request received - Payload: {JsonSerializer.Serialize(request)}");
-
-                if (string.IsNullOrEmpty(request.UserId)) { return BadRequest("Invalid user identifier"); }
-                if (string.IsNullOrEmpty(request.ProjectId)) { return BadRequest("Invalid project identifier"); }
-
-                return await Handle(() => thalosServiceClient.RemoveProjectFromUserService(request, cancellationToken)).ConfigureAwait(false);
-            }
-            catch (Exception ex)
-            {
-                logger.LogError($"{nameof(RemoveProjectFromUserService)} - An Error Occurred- {ex.Message} - {ex.InnerException} - {ex.StackTrace} - with payload {JsonSerializer.Serialize(request)}");
-                throw;
-            }
-        }
-
         /// <summary>
         /// Gets the user by email.
         /// </summary>

Core.Thalos.BFF.Api/Core.Thalos.BFF.Api.csproj

@@ -9,7 +9,7 @@
 
   <ItemGroup>
     <PackageReference Include="Asp.Versioning.Mvc" Version="8.1.0" />
-    <PackageReference Include="Core.Blueprint.Logging" Version="1.0.0" />
+    <PackageReference Include="Core.Blueprint.Logging" Version="1.0.1" />
   </ItemGroup>
 
   <ItemGroup>

Core.Thalos.BFF.Api/Program.cs

@@ -1,25 +1,30 @@
+using Core.Blueprint.KeyVault.Configuration;
 using Core.Blueprint.Logging.Configuration;
-using Core.Thalos.Adapters.Contracts;
+using Core.Thalos.BuildingBlocks;
-using Core.Thalos.Adapters.Extensions;
+using Core.Thalos.BuildingBlocks.Configuration;
-using Core.Thalos.Adapters.Services;
+using Core.Thalos.BuildingBlocks.Extensions;
-using Core.Thalos.BuildingBlocks.Authentication.Extensions;
 using Core.Thalos.External.ClientConfiguration;
 using Microsoft.AspNetCore.ResponseCompression;
 using OpenTelemetry.Logs;
 using OpenTelemetry.Resources;
-using Swashbuckle.AspNetCore.SwaggerUI;
 using System.IO.Compression;
 using System.Reflection;
 
 var builder = WebApplication.CreateBuilder(args);
 
-builder.Services.ConfigureAuthentication(builder.Configuration);
-
-builder.Services.AddEndpointsApiExplorer();
 builder.Configuration
     .AddUserSecrets(Assembly.GetExecutingAssembly())
     .AddEnvironmentVariables();
 
+var services = builder.Services.AddKeyVault(builder.Configuration);
+
+var authSettings = await AuthHelper.GetAuthSettings(builder.Services, builder, "thalos_common");
+
+builder.Services.ConfigureAuthentication(builder.Configuration, authSettings);
+
+builder.Services.AddEndpointsApiExplorer();
+
+
 builder.Services.AddResponseCompression();
 builder.Services.AddProblemDetails();
 builder.Services.AddLogs(builder);
@@ -82,20 +87,13 @@ builder.Host.ConfigureServices((context, services) =>
     });
     services.AddResponseCaching();
     services.AddControllers();
-    services.AddEndpointsApiExplorer();
+    services.AddSwaggerGen(builder.Configuration, "Core.Thalos.BFF.Api.xml", authSettings);
-    services.AddSwaggerGen(builder.Configuration);
+    services.AddVersioning(builder.Configuration);
     services.AddLogging();
     services.AddProblemDetails();
     services.AddHttpContextAccessor();
     services.AddTransient<TrackingMechanismExtension>(); // Register the TrackingIdHandler
     services.RegisterExternalLayer(builder.Configuration);
-
-    services.AddApiVersioning(options => options.ReportApiVersions = true)
-                   .AddApiExplorer(options =>
-                   {
-                       options.GroupNameFormat = "'v'VVV";
-                       options.SubstituteApiVersionInUrl = true;
-                   });
 });
 
 builder.Services.AddCors(options =>
@@ -111,30 +109,35 @@ builder.Services.AddCors(options =>
 
 builder.Services.AddScoped<ITokenService, TokenService>();
 
+builder.Services.AddOutputCache(options =>
+{
+    options.AddBasePolicy(builder =>
+        builder.Expire(TimeSpan.FromSeconds(10)));
+    options.AddPolicy("Expire20", builder =>
+        builder.Expire(TimeSpan.FromSeconds(20)));
+    options.AddPolicy("Expire30", builder =>
+        builder.Expire(TimeSpan.FromSeconds(30)));
+});
+
 //*************************************************************************//
 var app = builder.Build();
+app.UseLogging(builder.Configuration);
+app.UseSwaggerUI(builder.Configuration, authSettings);
+app.ConfigureSwagger(builder.Configuration);
 
 
-app.UseCors(options => options.AllowAnyHeader().AllowAnyMethod().AllowAnyOrigin());
+app.UseRouting();
-app.UseSwagger();
+app.UseCors();
-app.UseSwaggerUI(options =>
-{
-    foreach (var version in app.DescribeApiVersions().Select(version => version.GroupName))
-        options.SwaggerEndpoint($"/swagger/{version}/swagger.json", version);
-
-    options.DisplayRequestDuration();
-    options.EnableTryItOutByDefault();
-    options.DocExpansion(DocExpansion.None);
-});
-app.UseResponseCompression();
-app.UseResponseCaching();
 app.UseHttpsRedirection();
+app.UseStaticFiles();
+app.UseResponseCompression();
+app.UseOutputCache();
+app.UseResponseCaching();
 
 app.UseAuthentication();
 app.UseAuthorization();
+
 app.MapControllers();
-app.UseHsts();
+//app.MapHealthChecks("/health");
-app.UseAntiforgery();
-app.UseLogging(builder.Configuration);
 
 app.Run();

Core.Thalos.BFF.Api/appsettings.Local.json

@@ -8,18 +8,18 @@
   "LocalGateways": {
     "ThalosService": "https://localhost:7253/api"
   },
-  "Authentication": {
+  "ServiceSettings": {
-    "Google": {
+    "ApplicationName": "thalos",
-      "ClientId": "128345072002-mtfdgpcur44o9tbd7q6e0bb9qnp2crfp.apps.googleusercontent.com",
+    "LayerName": "bff"
-      "ClientSecret": "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",
+  },
-      "ApplicationName": "Thalos",
+  "Vault": {
-      "RedirectUri": "https://localhost:7239/api/v1/Authentication/callback"
+    "Address": "http://100.123.31.103:8200",
+    "Token": "hvs.e37LQvLuPhTd5ALS5QQ03Cwm",
+    "SecretMount": "secret"
+  },
+  "IdentityProviders": {
+    "Google": true,
+    "Azure": true
   }
-  },
-  "JwtIssuerOptions": {
-    "Audience": "https://localhost:7239/",
-    "Issuer": "webApi"
-  },
-  "SecretKey": "iNivDmHLpUA223sqsfhqGbMRdRj1PVkH1"
 }
 

Core.Thalos.External/ClientConfiguration/RegisterClientConfiguration.cs

@@ -1,6 +1,4 @@
-using Core.Thalos.Adapters.Contracts;
+using Core.Thalos.BuildingBlocks;
-using Core.Thalos.Adapters.Handlers;
-using Core.Thalos.Adapters.TokenProvider;
 using Core.Thalos.External.GatewayConfigurations;
 using LSA.Dashboard.External.Clients.Dashboard;
 using Microsoft.AspNetCore.Http;

Core.Thalos.External/Clients/Thalos/IThalosServiceClient.cs

@@ -1,6 +1,6 @@
-using Core.Thalos.Adapters;
+using Core.Thalos.Application.UseCases.Roles.Input;
-using Core.Thalos.Application.UseCases.Roles.Input;
 using Core.Thalos.Application.UseCases.Users.Input;
+using Core.Thalos.BuildingBlocks;
 using Core.Thalos.External.Clients.Thalos.Requests.Permissions;
 using Core.Thalos.External.Clients.Thalos.Requests.Users;
 using Microsoft.AspNetCore.Mvc;
@@ -40,18 +40,6 @@ namespace LSA.Dashboard.External.Clients.Dashboard
         [Patch("/v1/User/ChangeStatus")]
         Task<ApiResponse<UserAdapter>> ChangeUserStatusService([Header("TrackingId")][Body] ChangeUserStatusRequest request, CancellationToken cancellationToken = default);
 
-        [Post("/v1/User/AddCompany")]
-        Task<ApiResponse<UserAdapter>> AddCompanyToUserService([Header("TrackingId")][Body] AddCompanyToUserRequest request, CancellationToken cancellationToken = default);
-
-        [Delete("/v1/User/RemoveCompany")]
-        Task<ApiResponse<UserAdapter>> RemoveCompanyFromUserService([Header("TrackingId")][Body] RemoveCompanyFromUserRequest request, CancellationToken cancellationToken = default);
-
-        [Post("/v1/User/AddProject")]
-        Task<ApiResponse<UserAdapter>> AddProjectToUserService([Header("TrackingId")][Body] AddProjectToUserRequest request, CancellationToken cancellationToken = default);
-
-        [Delete("/v1/User/RemoveProject")]
-        Task<ApiResponse<UserAdapter>> RemoveProjectFromUserService([Header("TrackingId")][Body] RemoveProjectFromUserRequest request, CancellationToken cancellationToken = default);
-
         [Post("/v1/User/GetTokenAdapter")]
         Task<ApiResponse<TokenAdapter>> GetTokenAdapterService([Header("TrackingId")][Body] GetTokenAdapterRequest request, CancellationToken cancellationToken = default);
 

Core.Thalos.External/Clients/Thalos/Requests/Modules/CreateModuleRequest.cs

@@ -1,4 +1,4 @@
-using Core.Thalos.Adapters.Common.Enums;
+using Core.Thalos.BuildingBlocks;
 
 namespace Core.Thalos.External.Clients.Thalos.Requests.Permissions
 {

Core.Thalos.External/Clients/Thalos/Requests/Modules/UpdateModuleRequest.cs

@@ -1,5 +1,4 @@
-using Core.Blueprint.Mongo;
+using Core.Thalos.BuildingBlocks;
-using Core.Thalos.Adapters.Common.Enums;
 using StatusEnum = Core.Blueprint.Mongo.StatusEnum;
 
 namespace Core.Thalos.External.Clients.Thalos.Requests.Permissions

Core.Thalos.External/Clients/Thalos/Requests/Permissions/CreatePermissionRequest.cs

@@ -1,4 +1,4 @@
-using Core.Thalos.Adapters.Common.Constants;
+using Core.Thalos.BuildingBlocks;
 
 namespace Core.Thalos.External.Clients.Thalos.Requests.Permissions
 {

Core.Thalos.External/Clients/Thalos/Requests/Permissions/UpdatePermissionRequest.cs

@@ -1,4 +1,4 @@
-using Core.Thalos.Adapters.Common.Constants;
+using Core.Thalos.BuildingBlocks;
 using StatusEnum = Core.Blueprint.Mongo.StatusEnum;
 
 namespace Core.Thalos.External.Clients.Thalos.Requests.Permissions

Core.Thalos.External/Clients/Thalos/Requests/Roles/AddApplicationToRoleRequest.cs

@@ -1,4 +1,4 @@
-using Core.Thalos.Adapters.Common.Enums;
+using Core.Thalos.BuildingBlocks;
 
 namespace Core.Thalos.Application.UseCases.Roles.Input
 {

Core.Thalos.External/Clients/Thalos/Requests/Roles/CreateRoleRequest.cs

@@ -1,4 +1,4 @@
-using Core.Thalos.Adapters.Common.Enums;
+using Core.Thalos.BuildingBlocks;
 using System.Text.Json.Serialization;
 
 namespace Core.Thalos.Application.UseCases.Roles.Input

Core.Thalos.External/Clients/Thalos/Requests/Roles/RemoveApplicationFromRoleRequest.cs

@@ -1,4 +1,4 @@
-using Core.Thalos.Adapters.Common.Enums;
+using Core.Thalos.BuildingBlocks;
 
 namespace Core.Thalos.Application.UseCases.Roles.Input
 {

Core.Thalos.External/Clients/Thalos/Requests/Roles/UpdateRoleRequest.cs

@@ -1,4 +1,4 @@
-using Core.Thalos.Adapters.Common.Enums;
+using Core.Thalos.BuildingBlocks;
 using System.Text.Json.Serialization;
 using StatusEnum = Core.Blueprint.Mongo.StatusEnum;
 

Core.Thalos.External/Clients/Thalos/Requests/Users/AddCompanyToUserRequest.cs

@@ -1,8 +0,0 @@
-namespace Core.Thalos.Application.UseCases.Users.Input
-{
-    public class AddCompanyToUserRequest
-    {
-        public string UserId { get; set; }
-        public string CompanyId { get; set; }
-    }
-}

Core.Thalos.External/Clients/Thalos/Requests/Users/AddProjectToUserRequest.cs

@@ -1,8 +0,0 @@
-namespace Core.Thalos.Application.UseCases.Users.Input
-{
-    public class AddProjectToUserRequest
-    {
-        public string UserId { get; set; }
-        public string ProjectId { get; set; }
-    }
-}

Core.Thalos.External/Clients/Thalos/Requests/Users/CreateUserRequest.cs

@@ -7,8 +7,6 @@
         public string? MiddleName { get; set; }
         public string LastName { get; set; } = null!;
         public string RoleId { get; set; } = null!;
-        public string[] Companies { get; set; } = null!;
-        public string[]? Projects { get; set; }
         public bool SendInvitation { get; set; }
     }
 }

Core.Thalos.External/Clients/Thalos/Requests/Users/RemoveCompanyFromUserRequest.cs

@@ -1,8 +0,0 @@
-namespace Core.Thalos.Application.UseCases.Users.Input
-{
-    public class RemoveCompanyFromUserRequest
-    {
-        public string UserId { get; set; }
-        public string CompanyId { get; set; }
-    }
-}

Core.Thalos.External/Clients/Thalos/Requests/Users/RemoveProjectFromUserRequest.cs

@@ -1,8 +0,0 @@
-namespace Core.Thalos.Application.UseCases.Users.Input
-{
-    public class RemoveProjectFromUserRequest
-    {
-        public string UserId { get; set; }
-        public string ProjectId { get; set; }
-    }
-}

Core.Thalos.External/Core.Thalos.External.csproj

@@ -7,7 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Core.Thalos.BuildingBlocks" Version="1.0.5" />
+    <PackageReference Include="Core.Thalos.BuildingBlocks" Version="1.0.8" />
     <PackageReference Include="Lib.Architecture.BuildingBlocks" Version="1.0.0" />
     <PackageReference Include="Refit" Version="8.0.0" />
   </ItemGroup>