From f7adaf1b184a8de08364148c953a8687e0f426a7 Mon Sep 17 00:00:00 2001 From: Rodolfo Ruiz Date: Sat, 6 Sep 2025 20:45:56 -0600 Subject: [PATCH] chore: clean code, add delete --- src/api/ProductsApi.js | 4 +-- .../categories/AddOrEditCategoryForm.jsx | 16 ++++++------ .../catalogs/categories/Categories.jsx | 2 +- .../catalogs/products/ProductCollections.jsx | 26 +++++++++---------- src/private/users/UserManagement.jsx | 2 +- 5 files changed, 24 insertions(+), 26 deletions(-) diff --git a/src/api/ProductsApi.js b/src/api/ProductsApi.js index 2ee0d92..a2cbc8d 100644 --- a/src/api/ProductsApi.js +++ b/src/api/ProductsApi.js @@ -1,7 +1,7 @@ export default class ProductsApi { constructor(token) { this.baseUrl = 'https://inventory-bff.dream-views.com/api/v1/FurnitureVariant'; - this.token = token; + this.token = token; } headers(json = true) { @@ -53,7 +53,7 @@ export default class ProductsApi { return res.json(); } - async changeStatusVariant(payload) { + async changeStatusVariant(payload) { // If your API is change status, reuse updateVariant. const res = await fetch(`${this.baseUrl}/ChangeStatus`, { method: 'PATCH', diff --git a/src/private/catalogs/categories/AddOrEditCategoryForm.jsx b/src/private/catalogs/categories/AddOrEditCategoryForm.jsx index 1786cf9..60bcc28 100644 --- a/src/private/catalogs/categories/AddOrEditCategoryForm.jsx +++ b/src/private/catalogs/categories/AddOrEditCategoryForm.jsx @@ -52,14 +52,14 @@ export default function AddOrEditCategoryForm({ onAdd, initialData, onCancel, ma const [types, setTypes] = useState([]); const [allTags, setAllTags] = useState([]); -const tagLabelById = useMemo(() => { - const map = {}; - for (const t of allTags) { - const key = t._id; - map[key] = t.tagName || t.name || key; - } - return map; -}, [allTags]); + const tagLabelById = useMemo(() => { + const map = {}; + for (const t of allTags) { + const key = t._id; + map[key] = t.tagName || t.name || key; + } + return map; + }, [allTags]); const [form, setForm] = useState({ _id: '', diff --git a/src/private/catalogs/categories/Categories.jsx b/src/private/catalogs/categories/Categories.jsx index 48da03c..4a5a741 100644 --- a/src/private/catalogs/categories/Categories.jsx +++ b/src/private/catalogs/categories/Categories.jsx @@ -149,7 +149,7 @@ export default function Categories() { { field: 'actions', headerName: '', - width: 130, + width: 150, sortable: false, filterable: false, disableExport: true, diff --git a/src/private/catalogs/products/ProductCollections.jsx b/src/private/catalogs/products/ProductCollections.jsx index f0153f2..e42223b 100644 --- a/src/private/catalogs/products/ProductCollections.jsx +++ b/src/private/catalogs/products/ProductCollections.jsx @@ -43,7 +43,7 @@ export default function ProductCollections() { const tagTypeApi = useMemo(() => new TagTypeApi(token), [token]); const categoriesApi = useMemo(() => new CategoriesApi(token), [token]); - const toast = useApiToast(); + const { handleError } = useApiToast(); const [rows, setRows] = useState([]); const [rawRows, setRawRows] = useState([]); @@ -85,7 +85,7 @@ export default function ProductCollections() { return found?.tagName || String(value); }; }; - + // Cargar TagTypes + Tags useEffect(() => { let mounted = true; @@ -153,7 +153,7 @@ export default function ProductCollections() { setRawRows(normalized); } catch (err) { console.error(err); - toast.error(err?.message || 'Error loading variants'); + handleError(err, 'Error loading product collections'); } finally { setLoading(false); } @@ -177,12 +177,10 @@ export default function ProductCollections() { const confirmDelete = async () => { try { if (!editRow?.id) return; - await api.changeStatusVariant({ mongoId: editRow.id, status: 'Inactive' }); + await api.changeStatusVariant({ mongoId: editRow._Id, status: 'Inactive' }); await load(); - toast.success('Deleted successfully'); } catch (err) { console.error(err); - toast.error(err?.message || 'Delete failed'); } finally { setConfirmOpen(false); setEditRow(null); @@ -361,13 +359,13 @@ export default function ProductCollections() { setOpen(false)} maxWidth="md" fullWidth> - - {viewOnly - ? 'View Product Collection' - : editRow - ? 'Edit Product Collection' - : 'Add Product Collection'} - + + {viewOnly + ? 'View Product Collection' + : editRow + ? 'Edit Product Collection' + : 'Add Product Collection'} + - + setConfirmOpen(false)}> Delete Product Collection diff --git a/src/private/users/UserManagement.jsx b/src/private/users/UserManagement.jsx index d6ac9fb..e7c5b8e 100644 --- a/src/private/users/UserManagement.jsx +++ b/src/private/users/UserManagement.jsx @@ -102,7 +102,7 @@ export default function UserManagement() { status: r.status ?? 'Active', companies: Array.isArray(r.companies) ? r.companies : [], projects: Array.isArray(r.projects) ? r.projects : [], - }; + }; setEditingData(normalized); setOpen(true); };